Igore excessive fopen() mode flags for WritableResourceStream#119
Merged
WyriHaximus merged 2 commits intoreactphp:masterfrom Nov 10, 2017
Merged
Igore excessive fopen() mode flags for WritableResourceStream#119WyriHaximus merged 2 commits intoreactphp:masterfrom
WyriHaximus merged 2 commits intoreactphp:masterfrom
Conversation
Member
Author
|
For the reference: I consider this a low priority bug that I stumbled over while evaluating the |
kelunik
reviewed
Nov 9, 2017
Member
Author
|
Unrelated Mac OS X test failures are being addressed in #120 |
jsor
approved these changes
Nov 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a minor issue where valid stream resources opened with valid flags such as
rewhere not properly rejected.Builds on top of #83, #84, #85